Add connecting to database by connectionString given as an argument to cli #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Nov 17, 2024
|
I think your intuition is right, the main.go file need to be keep small, can you please move the command args processing to another file?. Also, can you please expand the "usage" section in the readme to include this? Thank you for the PR. |
ccoVeille
reviewed
Nov 19, 2024
|
I am facing an issue where only sqlite databases work with passing the argument. Postgresql connects without any problem but can't open unfold the left menu for listing the tables. |
|
I have tested MySQL, Postgres and SQLite and it works fine. Is there anything else you want to add or are we ready for merge? |
|
I don't have anything more. I'd be happy to see it merged :) |
ccoVeille
reviewed
Dec 1, 2024
|
Please fix linter errors. |
ccoVeille
suggested changes
Dec 3, 2024
ccoVeille
reviewed
Dec 4, 2024
added 11 commits
December 5, 2024 21:15
ccoVeille
reviewed
Dec 5, 2024
|
Thank you @ccoVeille for the good advices. I'm learning too, so thanks for taking the time to keep an eye on the project. |
ccoVeille
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the amazing tool!
I'd like to see a feature like this get merged as I find it easier to just pass the path to the database I want to open as an argument, so I made this request. This implementation works but perhaps is doing a bit too much in the main.go file. I first tried doing most of this connection initialization inside Pages.go but the init() functions run before main.go's main() function.
I'd love to hear your feedback on this!